Repository navigation
fix(observations): explicit clear resets the memory even with no observations to delete - #5775
Merged
Merged
Conversation
…rvations to delete (#5731) DELETE /memories/{id}/observations promised to reset the memory for re-consolidation, but only did so when it deleted at least one observation. A memory consolidation had kept nothing from stayed marked consolidated and no job was queued. The reset and the auto-consolidation submit now run on every explicit clear; the document change history still records a clear only when it removed observations. Review fixes: system story asserts the first consolidation pass ran; test helper documents why it reads the marker directly.
nicoloboschi
force-pushed
the
triage/5731
branch
from
October 19, 2026 16:08
0ff452f to
7a82438
Compare
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5731.
Problem
DELETE /v1/default/banks/{bank_id}/memories/{memory_id}/observationssays it resets the memory for re-consolidation and triggers a consolidation job. It only did either when it deleted at least one observation. A fact consolidation kept nothing from stays marked consolidated, so clearing it answered200 {"deleted_count": 0}and changed nothing.The
deleted_count > 0guards date back to the original import (#560); no recorded reason. This is not #5054 (automatic retry of skipped facts, by design): this is an explicit, operator-requested reset of one memory.Fix
clear_observations_for_memorynow always clears the memory's own consolidated marker and, when auto-consolidation is on, submits a job. Memory text, document, chunks andupdated_atare untouched, as before.Behaviour changes
Tests
test_no_observations_still_resets_memory(replaces the test that pinned the old behaviour) and an HTTP-route test. Both fail before, pass after.test_25_observation_lifecycle.py: consolidation keeps nothing, clearing that memory triggers a new pass that produces the observation. Fails before ("the cleared memory was never consolidated again"), passes after.Thanks @koriyoshi2041 for the independent repro and fix on the issue.