feat(crossseed): only poll status endpoints when features are enabled

[s0up4200]

Summary by CodeRabbit

• Improvements
  • Polling now respects RSS enablement and reduces unnecessary requests when disabled.
  • Search-status polling dynamically increases during active searches and slows when idle for efficiency.
  • Instance state now exposes loading, error and status indicators so UI shows current fetch state more reliably.
  • UI layout components updated to consume the consolidated instance state shape.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Replaces the previous raw return of useCrossSeedInstanceState with a typed object, adds settingsQuery to determine rssEnabled, gates status/search queries on rssEnabled, implements dynamic polling intervals for search status, refactors state memoization, and updates three UI call sites to destructure the hook's state property.

Changes

Cohort / File(s)	Summary
Cross-seed instance state hook web/src/hooks/useCrossSeedInstanceState.ts	Introduces public return type CrossSeedInstanceStateResult and changes export to useCrossSeedInstanceState(): CrossSeedInstanceStateResult. Adds settingsQuery to compute rssEnabled; gates status/search queries with enabled: rssEnabled; implements dynamic refetchInterval (5s when searching, 60s otherwise); recalculates per-target state only when rssEnabled is true; returns state, isLoading, isError, and error.
Hook call sites — UI components web/src/components/layout/Header.tsx, web/src/components/layout/MobileFooterNav.tsx, web/src/components/layout/Sidebar.tsx	Update call sites to destructure the hook result and use the state property: const { state: crossSeedInstanceState } = useCrossSeedInstanceState() (replacing previous direct assignment). No other logic changes at call sites.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Areas needing attention:
  • Correctness of rssEnabled gating and interaction with enabled flags on queries
  • Polling intervals and conditional refetchInterval behavior for search status
  • Memoization dependencies and construction of per-target state
  • Call-site updates to ensure no remaining usages assume the old return shape

Possibly related PRs

• feat(crossseed): persist seeded search settings #618 — Adds cross-seed search settings API/types and client methods which the new settingsQuery usage depends on.
• fix(torznab): filter Prowlarr autodiscovery to enabled torrent indexers #638 — Also modifies the cross-seed instance state hook and related call sites; likely coordinated changes to return shape and UI handling.

Suggested labels

cross-seed, web

Poem

🐰 I nibbled code beneath the moonlit tree,
Polling hops at five, then thirty, whee!
I tuck RSS flags into my burrowed state,
Destructure my pockets — everything's straight.
Hooray for tidy returns and a hopping update!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: conditional polling of cross-seed status endpoints based on feature enablement (rssEnabled gating).

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/conditional-crossseed-polling

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/src/hooks/useCrossSeedInstanceState.ts (1)

37-40: Consider explicit typing for the query parameter.

The dynamic polling logic correctly implements search-active-only polling. For improved type safety and code clarity, consider explicitly typing the function parameter.

-    refetchInterval: (query) => {
+    refetchInterval: (query: { state: { data?: { running?: boolean } } }) => {
       // Only poll while a search is actively running
       return query.state.data?.running ? 5_000 : false
     },

Alternatively, import the Query type from @tanstack/react-query:

import { useQuery, type Query } from "@tanstack/react-query"

// Then use:
refetchInterval: (query: Query) => {
  return query.state.data?.running ? 5_000 : false
},

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3baa007 and 1196715.

📒 Files selected for processing (1)

• web/src/hooks/useCrossSeedInstanceState.ts (2 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:209-212
Timestamp: 2025-11-28T20:32:30.126Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The cross-seed recheck-resume worker intentionally runs for the process lifetime and keys pending entries by hash only. This is acceptable under the current constraint that background seeded-search runs operate on a single instance at a time; graceful shutdown and instanceID|hash keying are deferred by design.

📚 Learning: 2025-11-28T20:32:30.126Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:209-212
Timestamp: 2025-11-28T20:32:30.126Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The cross-seed recheck-resume worker intentionally runs for the process lifetime and keys pending entries by hash only. This is acceptable under the current constraint that background seeded-search runs operate on a single instance at a time; graceful shutdown and instanceID|hash keying are deferred by design.

Applied to files:

• web/src/hooks/useCrossSeedInstanceState.ts

🧬 Code graph analysis (1)

web/src/hooks/useCrossSeedInstanceState.ts (1)

web/src/lib/api.ts (1)

• api (1696-1696)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run tests

🔇 Additional comments (4)

web/src/hooks/useCrossSeedInstanceState.ts (4)

13-20: LGTM! Settings caching strategy is well-chosen.

The 5-minute stale time and 10-minute GC time are appropriate for settings that rarely change, reducing unnecessary API calls while ensuring reasonably fresh data.

---

22-22: LGTM! Safe extraction with fail-safe default.

The nullish coalescing provides a conservative default when settings are unavailable, preventing unnecessary polling during errors or initial load.

---

24-31: LGTM! Conditional polling correctly implemented.

The combination of enabled: rssEnabled and conditional refetchInterval ensures the status endpoint is only queried when RSS automation is active, achieving the PR objective efficiently.

---

44-67: LGTM! Conditional state population correctly gated.

The if (rssEnabled) guard prevents unnecessary state entries when RSS is disabled, and adding rssEnabled to the dependency array ensures the memo recalculates appropriately when RSS status changes.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/src/hooks/useCrossSeedInstanceState.ts (1)

47-54: Variable rssEnabled shadows outer declaration.

The rssEnabled on line 52 shadows the one declared on line 27. While functionally equivalent, this can cause confusion during maintenance. Consider renaming to make the data flow clearer.

   const state = useMemo(() => {
     const settings = settingsQuery.data
     const crossSeedStatus = statusQuery.data
     const crossSeedSearchStatus = searchStatusQuery.data
 
-    const rssEnabled = settings?.enabled ?? false
+    const isRssEnabled = settings?.enabled ?? false
     const rssRunning = crossSeedStatus?.running ?? false
     const rssTargetIds = crossSeedStatus?.settings?.targetInstanceIds ?? []

Then update usage on line 60 and 62 accordingly.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1196715 and 1dbc8ae.

📒 Files selected for processing (4)

• web/src/components/layout/Header.tsx (1 hunks)
• web/src/components/layout/MobileFooterNav.tsx (1 hunks)
• web/src/components/layout/Sidebar.tsx (1 hunks)
• web/src/hooks/useCrossSeedInstanceState.ts (2 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:209-212
Timestamp: 2025-11-28T20:32:30.126Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The cross-seed recheck-resume worker intentionally runs for the process lifetime and keys pending entries by hash only. This is acceptable under the current constraint that background seeded-search runs operate on a single instance at a time; graceful shutdown and instanceID|hash keying are deferred by design.

📚 Learning: 2025-11-28T20:32:30.126Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:209-212
Timestamp: 2025-11-28T20:32:30.126Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The cross-seed recheck-resume worker intentionally runs for the process lifetime and keys pending entries by hash only. This is acceptable under the current constraint that background seeded-search runs operate on a single instance at a time; graceful shutdown and instanceID|hash keying are deferred by design.

Applied to files:

• web/src/hooks/useCrossSeedInstanceState.ts

🧬 Code graph analysis (3)

web/src/hooks/useCrossSeedInstanceState.ts (1)

web/src/lib/api.ts (1)

• api (1696-1696)

web/src/components/layout/MobileFooterNav.tsx (1)

web/src/hooks/useCrossSeedInstanceState.ts (1)

• useCrossSeedInstanceState (19-82)

web/src/components/layout/Header.tsx (1)

web/src/hooks/useCrossSeedInstanceState.ts (1)

• useCrossSeedInstanceState (19-82)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run tests

🔇 Additional comments (5)

web/src/hooks/useCrossSeedInstanceState.ts (2)

37-45: searchStatusQuery always polls regardless of feature state.

The PR objective is to "only poll status endpoints when features are enabled", but searchStatusQuery runs unconditionally. Consider whether this query should also be gated (e.g., by a setting or by checking if cross-seed is configured at all) to fully achieve the optimization goal.

If this is intentional (e.g., to detect new searches started externally), the 60-second idle interval is reasonable, but it might be worth adding a brief comment explaining why this query isn't gated.

---

76-81: LGTM!

The aggregated loading/error states correctly handle the case where statusQuery may be disabled. TanStack Query v5 properly reports isLoading: false for disabled queries, so the OR aggregation works as expected.

web/src/components/layout/Header.tsx (1)

172-172: LGTM!

The destructuring correctly adapts to the new CrossSeedInstanceStateResult return type while maintaining the same variable name for downstream usage.

web/src/components/layout/Sidebar.tsx (1)

90-90: LGTM!

Consistent with the changes in Header.tsx, the destructuring correctly adapts to the new hook return type.

web/src/components/layout/MobileFooterNav.tsx (1)

122-122: LGTM!

Consistent with the changes in Header.tsx and Sidebar.tsx. All three consumer components now correctly destructure the state property from the updated hook.