feat(tracker): add per-domain stats inclusion toggle for merged trackers

[s0up4200]

Summary

• Add per-domain checkbox to control which domains contribute to combined stats when merging trackers
• Add ScrollArea for scrollable domain list when many domains are merged
• Add X button to remove domains from within the customize dialog
• Add toast notifications for mutation failures

This addresses the use case where:

• Same tracker with multiple URLs (e.g., TorrentLeech): should NOT sum stats (would double-count)
• Different trackers grouped together (e.g., Public Trackers): may want to sum stats

Primary domain is always included. Secondary domains are only included if explicitly checked.

Empty includedInStats means only primary domain stats shown, which is backwards compatible with existing customizations.

Test plan

• Create new tracker customization with multiple domains, verify checkbox behavior
• Edit existing customization, verify includedInStats persists correctly
• Verify stats calculation changes based on checkbox state
• Test import/export includes includedInStats field
• Verify existing customizations continue to work (only primary stats shown)
• Verify toast appears on mutation failures

Summary by CodeRabbit

• New Features

  • Added ability to selectively include secondary domains in tracker statistics. Users can now configure which secondary domains' data contributes to combined stat totals through domain inclusion toggles.

• Improvements

  • Enhanced error notifications for tracker customization operations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds an IncludedInStats field to tracker customizations, enabling secondary domains to be selectively included in combined statistics. Changes include database migration, backend model and API handler updates to sanitize and persist the field, TypeScript type additions, enhanced error handling in mutation hooks, and Dashboard UI modifications for domain management and two-pass stats aggregation.

Changes

Cohort / File(s)	Summary
Database and Models internal/database/migrations/034_add_tracker_customization_included_stats.sql, internal/models/tracker_customization.go	Added included_in_stats column (TEXT, comma-separated domains) to tracker_customizations table. Extended List, Get, Create, and Update queries to select, scan, and persist the new column; added string/slice conversions via splitDomains/joinDomains helpers.
API Handler internal/api/handlers/tracker_customizations.go	Added IncludedInStats field to TrackerCustomizationPayload. Introduced sanitizeIncludedInStats() helper to filter included domains against valid secondary domains. Extended toModel() to compute and attach sanitized IncludedInStats, trim DisplayName, and precompute Domains.
Frontend Types web/src/types/index.ts	Added optional includedInStats?: string[] property to TrackerCustomization and TrackerCustomizationInput types.
Frontend Hooks web/src/hooks/useTrackerCustomizations.ts	Enhanced error handling in create, update, and delete mutation hooks to display user-facing toast notifications on failure.
Frontend UI web/src/pages/Dashboard.tsx	Added ScrollArea import for scrollable domain lists. Introduced two-pass stats aggregation: Pass 1 creates primary/standalone entries, Pass 2 merges stats from explicitly included secondary domains. Extended tracker customization dialog with domain management UI (per-domain inclusion toggles, removal, primary-domain labels). Updated create/update/import/export cycles to propagate includedInStats.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~45 minutes

• web/src/pages/Dashboard.tsx: Two-pass aggregation logic for merging secondary domain stats into primary entries; ensure correct stat accumulation and domain filtering.
• internal/models/tracker_customization.go: String/slice conversion patterns (splitDomains/joinDomains) applied across four database operations; verify consistency in data transformation.
• internal/api/handlers/tracker_customizations.go: Validation logic in sanitizeIncludedInStats() to exclude primary domains and ensure existence in domains list; confirm filtering rules are correct.

Possibly related PRs

• feat(web): share tracker customizations with filtersidebar #717: Modifies FilterSidebar feature that leverages the new includedInStats field for secondary-domain grouping and stat aggregation.
• feat(dashboard): tracker breakdown and customizable layout #637: Extends tracker customizations directly overlapping with this PR, introducing related dashboard-level tracker customization and domain-merging functionality.
• fix(dashboard): merge tracker customizations with duplicate displayName #751: Modifies Dashboard.tsx tracker customization creation/update flows and domain-merging logic, intersecting with this PR's changes.

Suggested labels

enhancement, web, database:migrations, database

Poem

🐰 Secondary stats now dance in sight,
Domains join primary in unified flight,
With toggles and filters, clean and bright—
Two-pass aggregation, perfectly tight!
Stats bloom where they're meant to be right. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat(tracker): add per-domain stats inclusion toggle for merged trackers' accurately and concisely describes the main change: introducing a per-domain toggle mechanism for controlling which domains contribute to combined stats.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/tracker-stats-per-domain-inclusion

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/src/pages/Dashboard.tsx (1)

1983-2023: Well-designed dialog UI with ScrollArea for domain lists.

The per-domain checkbox pattern clearly communicates that:

• Primary domain (index 0) is always included (checkbox disabled)
• Secondary domains can be toggled for stats inclusion
• The "Primary" badge provides visual clarity

The X button to remove domains enhances usability for large merge groups.

For improved screen reader accessibility, consider associating each checkbox with an explicit label using htmlFor and id attributes:

-<Checkbox
-  checked={isIncluded}
-  disabled={isPrimary}
-  onCheckedChange={(checked) => handleToggleStatsInclusion(domain, !!checked)}
-  className="h-4 w-4"
-/>
-<span className={isPrimary ? "font-medium flex-1" : "flex-1"}>{domain}</span>
+<Checkbox
+  id={`include-stats-${domain}`}
+  checked={isIncluded}
+  disabled={isPrimary}
+  onCheckedChange={(checked) => handleToggleStatsInclusion(domain, !!checked)}
+  className="h-4 w-4"
+/>
+<Label htmlFor={`include-stats-${domain}`} className={isPrimary ? "font-medium flex-1 cursor-pointer" : "flex-1 cursor-pointer"}>
+  {domain}
+</Label>

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c66ba5 and 5419a45.

📒 Files selected for processing (6)

• internal/api/handlers/tracker_customizations.go (1 hunks)
• internal/database/migrations/034_add_tracker_customization_included_stats.sql (1 hunks)
• internal/models/tracker_customization.go (6 hunks)
• web/src/hooks/useTrackerCustomizations.ts (4 hunks)
• web/src/pages/Dashboard.tsx (18 hunks)
• web/src/types/index.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📚 Learning: 2025-12-07T21:15:46.265Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 637
File: internal/api/handlers/tracker_customizations.go:138-154
Timestamp: 2025-12-07T21:15:46.265Z
Learning: In the qui codebase (internal/api/handlers/tracker_customizations.go and internal/models/tracker_customization.go), domain normalization follows a layered pattern: the handler's normalizeDomains performs input sanitization at the API boundary (trim, lowercase, deduplicate), while the store's joinDomains is only for serialization. All domains flow through the handler first, ensuring they're normalized before reaching the store layer.

Applied to files:

• internal/api/handlers/tracker_customizations.go
• internal/models/tracker_customization.go
• web/src/pages/Dashboard.tsx

📚 Learning: 2025-11-25T11:39:54.748Z

Learnt from: s0up4200
Repo: autobrr/qui PR: 637
File: web/src/pages/Dashboard.tsx:805-831
Timestamp: 2025-11-25T11:39:54.748Z
Learning: In web/src/pages/Dashboard.tsx, the TrackerIconImage component intentionally receives displayDomain (incognito-mapped name) instead of the real domain in incognito mode. This causes icon lookups to fail and show only fallback letters, which is desired behavior for privacy - hiding both tracker names and icons when incognito mode is enabled.

Applied to files:

• web/src/pages/Dashboard.tsx

📚 Learning: 2025-12-03T18:11:08.682Z

Learnt from: finevan
Repo: autobrr/qui PR: 677
File: web/src/components/torrents/AddTorrentDialog.tsx:496-504
Timestamp: 2025-12-03T18:11:08.682Z
Learning: In the AddTorrentDialog component (web/src/components/torrents/AddTorrentDialog.tsx), temporary path settings (useDownloadPath/downloadPath) should be applied per-torrent rather than updating global instance preferences. The UI/UX is designed to suggest that these options apply to the individual torrent being added.

Applied to files:

• web/src/pages/Dashboard.tsx

🧬 Code graph analysis (2)

internal/models/tracker_customization.go (1)

web/src/types/index.ts (1)

• TrackerCustomization (320-327)

web/src/pages/Dashboard.tsx (5)

web/src/components/ui/dialog.tsx (3)

• DialogContent (138-138)
• DialogDescription (139-139)
• DialogHeader (141-141)

web/src/components/ui/label.tsx (1)

• Label (29-29)

web/src/components/ui/scroll-area.tsx (1)

• ScrollArea (61-61)

web/src/components/ui/checkbox.tsx (1)

• Checkbox (43-43)

web/src/components/ui/badge.tsx (1)

• Badge (51-51)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run tests

🔇 Additional comments (16)

internal/database/migrations/034_add_tracker_customization_included_stats.sql (1)

1-7: LGTM!

Clean migration that adds the new column with appropriate defaults for backwards compatibility. The TEXT type with empty string default aligns with the existing domains column pattern.

web/src/types/index.ts (1)

320-333: LGTM!

Type definitions correctly mirror the backend model with optional includedInStats arrays. The optional nature preserves backwards compatibility with existing customizations.

web/src/hooks/useTrackerCustomizations.ts (1)

36-40: LGTM!

Toast notifications provide good user feedback on mutation failures. The generic error messages are appropriate to avoid leaking implementation details.

internal/models/tracker_customization.go (3)

16-23: LGTM!

The struct updates follow the established pattern for the domains field. The omitempty JSON tag ensures backwards-compatible serialization where empty arrays are omitted.

---

33-64: LGTM!

List and Get methods correctly extend the SELECT queries and scan logic to handle the new included_in_stats column, reusing the existing splitDomains helper for consistent deserialization.

---

86-136: LGTM!

Create and Update methods properly persist the IncludedInStats field using the existing joinDomains helper, which also handles deduplication.

internal/api/handlers/tracker_customizations.go (2)

34-44: LGTM!

The toModel method correctly normalizes domains first, then sanitizes IncludedInStats to ensure only valid secondary domains are persisted.

---

46-70: Well-implemented sanitization logic.

The sanitizeIncludedInStats function correctly:

1. Returns nil for empty inputs (avoiding unnecessary allocations)
2. Excludes the primary domain (index 0) from valid inclusion candidates
3. Filters to only domains that exist in the customization

This ensures data integrity at the API boundary, consistent with the layered normalization pattern. Based on learnings, this follows the codebase convention where handlers perform input sanitization.

web/src/pages/Dashboard.tsx (8)

910-911: LGTM!

State additions properly track includedInStats for both editing existing customizations and creating new ones. Using a Set for new customizations aligns with the existing selectedDomains pattern.

---

945-997: Well-designed two-pass aggregation.

The algorithm correctly handles the case where domains may appear in any order in the aggregated map:

• Pass 1 creates entries for primary domains (always included) and standalone domains
• Pass 2 merges stats from secondary domains only when explicitly in includedInStats

The if (existing) guard in Pass 2 (line 987) safely handles edge cases where the primary domain has no stats.

---

1062-1135: LGTM!

The save handler correctly propagates includedInStats through create, update, and merge flows. The merge scenario (lines 1100-1108) appropriately combines existing and new inclusions, relying on backend sanitization for deduplication.

---

1203-1244: LGTM!

Domain management handlers correctly maintain state consistency:

• handleRemoveDomainFromDialog removes domains from both the domain list and includedInStats
• handleToggleStatsInclusion uses case-insensitive filtering before adding to prevent duplicates

The guard newDomains.length > 0 prevents accidentally removing all domains.

---

1253-1266: LGTM!

Export logic correctly includes includedInStats only when non-empty, keeping the JSON clean and backwards-compatible with older imports that don't have this field.

---

1325-1347: LGTM!

Import parsing correctly handles the optional includedInStats field with a default empty array, ensuring backwards compatibility with exports from before this feature was added.

---

1158-1168: LGTM!

The openEditDialog function correctly retrieves the full customization from the query cache to populate includedInStats, with appropriate fallback to an empty array.

---

1196-1201: LGTM!

Dialog close handler properly resets includedInStats state to prevent stale data when reopening the dialog.