fix(web): sort Peers column by total peers instead of connected

[s0up4200]

Summary

• Maps num_leechs → num_incomplete when sorting by Peers column
• Matches the Seeds fix from fix(web): sort Seeds column by total seeds instead of connected #747 (num_seeds → num_complete)
• Now sorting uses total peers in swarm instead of currently connected peers

Fixes #750

Summary by CodeRabbit

• Bug Fixes
  • Corrected torrent sorting by seed and leech counts to ensure accurate result ordering in torrent list views.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Modified backend sort field mappings in two torrent components to include inactive torrents when sorting by seeds and leeches. The frontend "num_seeds" and "num_leechs" fields now map to backend "num_complete" and "num_incomplete" fields respectively, ensuring comprehensive torrent ordering.

Changes

Cohort / File(s)	Summary
Backend sort field mappings web/src/components/torrents/TorrentCardsMobile.tsx, web/src/components/torrents/TorrentTableOptimized.tsx	Extended sort field mappings to remap "num_seeds" → "num_complete" and "num_leechs" → "num_incomplete", allowing sorting to include both active and inactive torrents

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Simple and consistent mapping logic applied uniformly across two files
• No control flow or error handling changes
• Direct mapping transformation with no side effects

Possibly related PRs

• fix(web): sort Seeds column by total seeds instead of connected #747 — Related PR that introduces the initial num_seeds → num_complete mapping; this change extends that mapping with additional num_leechs handling

Suggested labels

bugfix, web, torrent

Poem

🐰 With whiskers twitching, we fixed the seed,
No longer just active, but all that we need,
Inactive and bustling, now sorted with care,
The leeches and seeders, all counted fair! 🌱

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: fixing sort behavior for the Peers column to use total peers instead of connected peers.
Linked Issues check	✅ Passed	The PR addresses issue #750 by mapping num_leechs to num_incomplete and num_seeds to num_complete, implementing the expected behavior of including inactive peers in sorting.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing seed and peer column sorting behavior as specified in issue #750; no extraneous modifications detected.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/peers-column-sorting

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/src/components/torrents/TorrentCardsMobile.tsx (1)

946-946: LGTM! Consistent mapping for mobile view.

The extended ternary chain correctly maps both num_seeds → num_complete and num_leechs → num_incomplete, ensuring consistent sorting behavior between desktop and mobile views.

The ternary chain is becoming longer and could benefit from extraction to a helper function for better maintainability:

+// Map frontend sort fields to backend field names
+const getBackendSortField = (field: TorrentSortOptionValue): string => {
+  if (field === "num_seeds") return "num_complete"
+  if (field === "num_leechs") return "num_incomplete"
+  return field
+}
+
 const sortField = sortState.field
 const sortOrder = sortState.order

 // Map sort field to backend field name (e.g., num_seeds -> num_complete)
-const backendSortField = sortField === "num_seeds" ? "num_complete" : sortField === "num_leechs" ? "num_incomplete" : sortField
+const backendSortField = getBackendSortField(sortField)

This would also align the mobile implementation more closely with the desktop's switch statement approach.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5ede56 and 0b22452.

📒 Files selected for processing (2)

• web/src/components/torrents/TorrentCardsMobile.tsx (1 hunks)
• web/src/components/torrents/TorrentTableOptimized.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-11-06T11:59:21.390Z

Learnt from: Audionut
Repo: autobrr/qui PR: 553
File: web/src/components/torrents/TorrentTableOptimized.tsx:1510-1515
Timestamp: 2025-11-06T11:59:21.390Z
Learning: In the qui project, the API layer in web/src/lib/api.ts normalizes backend snake_case responses to camelCase for frontend consumption. For CrossSeed search results, the backend's download_url field is transformed to downloadUrl in the searchCrossSeedTorrent method, so frontend code should always use the camelCase variant (result.downloadUrl).

Applied to files:

• web/src/components/torrents/TorrentCardsMobile.tsx

📚 Learning: 2025-12-03T18:11:08.682Z

Learnt from: finevan
Repo: autobrr/qui PR: 677
File: web/src/components/torrents/AddTorrentDialog.tsx:496-504
Timestamp: 2025-12-03T18:11:08.682Z
Learning: In the AddTorrentDialog component (web/src/components/torrents/AddTorrentDialog.tsx), temporary path settings (useDownloadPath/downloadPath) should be applied per-torrent rather than updating global instance preferences. The UI/UX is designed to suggest that these options apply to the individual torrent being added.

Applied to files:

• web/src/components/torrents/TorrentTableOptimized.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run tests

🔇 Additional comments (1)

web/src/components/torrents/TorrentTableOptimized.tsx (1)

974-975: LGTM! Correct mapping for total peer sorting.

The addition of the num_leechs → num_incomplete mapping correctly implements sorting by total peers (including inactive) rather than just connected peers. This mirrors the existing seeds mapping pattern and is consistent throughout the codebase—the same mapping logic exists in TorrentCardsMobile.tsx (line 946), and both fields are properly defined in the data model and actively used for display in TorrentTableColumns.tsx.