fix(crossseed): fix batch completion searches and remove legacy settings

[s0up4200]

Summary

• Fix batch completion searches: When multiple torrents complete close together (e.g., downloading a full season), completion searches would previously be skipped due to rate limiting. Now they queue and wait their turn, ensuring all torrents get cross-seed searches.
• Remove legacy completion settings: Drops the deprecated CrossSeedCompletionSettings structure and related database columns that were superseded by per-instance completion settings.

Root Cause

The completion search maxWait (30s) was shorter than the effective rate limit interval (42s). When torrents completed within seconds of each other, all indexers would be skipped because the required wait exceeded the max allowed wait time.

Fix

Completion searches now have no maxWait limit (like interactive searches). They queue and execute in order as rate limits clear, instead of being immediately skipped.

Summary by CodeRabbit

• Breaking Changes

  • Removed completion configuration and related filters from cross-seed automation settings; completion fields are no longer supported.

• Improvements

  • Simplified automation settings and API patch behavior with more optional/nullable fields.
  • Scheduler behavior adjusted: longer waits and completion-priority tasks now queue (no fixed per-priority cap).

• Chores

  • Database migration to remove legacy completion columns.

• Tests

  • Updated tests to reflect removal of completion and new scheduler semantics.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Removed per-automation and global "completion" settings from cross-seed: deleted related types/fields, removed DB columns via migration, updated API/OpenAPI/web types and tests, adjusted cross-seed service and Jackett scheduler timeouts/limits and related tests.

Changes

Cohort / File(s)	Summary
API Handler internal/api/handlers/crossseed.go	Deleted completion request/patch types and Completion fields; converted several patch fields to pointer/optional types; removed completion patch apply logic and updated isEmpty checks.
API Handler Tests internal/api/handlers/crossseed_patch_test.go	Removed Completion initialization and assertions from patch tests; adapted tests to new patch semantics.
Data Model internal/models/crossseed.go	Removed CrossSeedCompletionSettings type and Completion field from CrossSeedAutomationSettings; deleted getters and normalization; removed completion columns from DB queries and encode/decode paths; updated defaults.
Data Model Tests internal/models/crossseed_test.go	Removed Completion fields and assertions from UpsertSettings test.
Database Migration internal/database/migrations/030_remove_legacy_completion_columns.sql	Added migration recreating cross_seed_settings without legacy completion columns, copying data, dropping old table, renaming new table, and recreating updated_at trigger.
Cross-Seed Service internal/services/crossseed/service.go	Removed normalization calls for completion settings in load/validate paths; adjusted completion search timeout log level/message.
Jackett Scheduler internal/services/jackett/scheduler.go, internal/services/jackett/SCHEDULER.md	Removed fixed completionMaxWait; increased background defaults (45s → 60s); increased completion/background execution timeouts; getMaxWait() returns 0 for completion (no per-priority cap).
Jackett Scheduler Tests internal/services/jackett/scheduler_test.go	Updated rate-limiter interval and expected waits; removed completion skip case; added subtest ensuring Completion-priority jobs queue (no hard skip).
Jackett Service internal/services/jackett/service.go	Stopped setting MaxWait for RateLimitPriorityCompletion; clarified behavior in comments.
OpenAPI internal/web/swagger/openapi.yaml	Removed CrossSeedCompletionSettingsPatch schema and removed completion fields from CrossSeedAutomationSettings and its Patch schema.
Web Types web/src/types/index.ts	Removed CrossSeedCompletionSettings / CrossSeedCompletionSettingsPatch interfaces and deleted completion fields from automation interfaces.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

• Pay special attention to the DB migration SQL for correctness and data preservation.
• Verify all serialization/DB encode-decode paths no longer reference completion columns.
• Confirm patch semantics (pointer/optional fields) are handled consistently across API handlers and tests.
• Review Jackett scheduler changes for queueing and rate-limit implications.

Possibly related PRs

• autobrr/qui#614 — Previously added PATCH support including completion patch types and merge logic (directly related to the removed types/logic).
• autobrr/qui#736 — Overlaps cross-seed completion additions/removal and touches the same handlers/models/OpenAPI.
• autobrr/qui#641 — Modifies Jackett scheduler and rate-limiting behavior tied to completion priorities and timeouts.

Suggested labels

bugfix

Suggested reviewers

• Audionut

Poem

I hop through code with floppy ears,
Nibbling completion’s last small gears,
Fields gone, tables trimmed with care,
Queues now wait and logs declare —
A lighter trail of bytes I share 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: fixing batch completion searches and removing legacy completion settings from the CrossSeed functionality.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3cffaf4 and c6f0d9b.

📒 Files selected for processing (1)

• internal/services/crossseed/service.go (2 hunks)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

internal/services/jackett/SCHEDULER.md (1)

228-241: Consider documenting execution timeouts alongside MaxWait defaults.

The AI summary mentions that execution timeouts were adjusted (completionExecutionTimeout: 30s→45s, backgroundExecutionTimeout: 45s→60s), but these aren't shown in the Configuration section. While MaxWait and execution timeouts are separate concerns (dispatch vs. execution), documenting both together would provide a complete picture of scheduler limits for different priorities.

Consider adding an "Execution Timeouts" subsection after line 241:

### Execution Timeouts

```go
const (
    completionExecutionTimeout = 45 * time.Second
    backgroundExecutionTimeout = 60 * time.Second
    rssExecutionTimeout        = 45 * time.Second
)

These timeouts limit how long a single search execution can run before being cancelled.

</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used**: CodeRabbit UI

**Review profile**: CHILL

**Plan**: Pro

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 438252b11c66939582a8e8102080322463b92a34 and 3cffaf4df0c45a84c069655ada50896c2e8c5c45.

</details>

<details>
<summary>📒 Files selected for processing (2)</summary>

* `internal/services/crossseed/service.go` (1 hunks)
* `internal/services/jackett/SCHEDULER.md` (2 hunks)

</details>

<details>
<summary>🚧 Files skipped from review as they are similar to previous changes (1)</summary>

* internal/services/crossseed/service.go

</details>

<details>
<summary>🧰 Additional context used</summary>

<details>
<summary>🧠 Learnings (1)</summary>

<details>
<summary>📓 Common learnings</summary>

Learnt from: s0up4200
Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go:209-212
Timestamp: 2025-11-28T20:32:30.126Z
Learning: Repo: autobrr/qui PR: 641
File: internal/services/crossseed/service.go
Learning: The cross-seed recheck-resume worker intentionally runs for the process lifetime and keys pending entries by hash only. This is acceptable under the current constraint that background seeded-search runs operate on a single instance at a time; graceful shutdown and instanceID|hash keying are deferred by design.

</details>

</details>

</details>

<details>
<summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)</summary>

* GitHub Check: Run tests

</details>

<details>
<summary>🔇 Additional comments (2)</summary><blockquote>

<details>
<summary>internal/services/jackett/SCHEDULER.md (2)</summary><blockquote>

`236-240`: **Documentation clearly reflects the removal of completionMaxWait and the new queuing behavior.**

The update to lines 238-239 effectively communicates the shift: completion and interactive searches now have no maxWait limit and will queue indefinitely instead of being skipped. This directly addresses the PR objective and is well-documented.

---

`243-266`: **getMaxWait() implementation documentation accurately reflects the new priority-based defaults.**

The function now correctly shows Completion priority returning 0 (matching Interactive), enabling the queuing behavior described in the PR objectives. The inline comments at lines 254-263 clearly explain each priority's behavior, making it easy for developers to understand why completion searches can wait indefinitely while background searches have a 60s timeout.

</blockquote></details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->