Repository navigation
fix: declare the dependencies the simulator, e2e and map packages use - #13209
Merged
xmfcx merged 2 commits intoAug 17, 2026
Merged
Conversation
Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
xmfcx
marked this pull request as ready for review
August 15, 2026 07:55
xmfcx
requested review from
Max-Bin,
Motsu-san,
Shin-kyoto,
TaikiYamada4,
YamatoAndo and
yukkysaito
as code owners
August 15, 2026 07:55
4 of 11 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13209 +/- ##
==========================================
- Coverage 20.35% 20.35% -0.01%
==========================================
Files 1946 1946
Lines 136634 136634
Branches 48746 48746
==========================================
- Hits 27818 27817 -1
Misses 86282 86282
- Partials 22534 22535 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mitsudome-r
approved these changes
Aug 17, 2026
YamatoAndo
approved these changes
Aug 17, 2026
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 7, 2026
…autowarefoundation#13209) * fix: declare the dependencies the simulator, e2e and map packages use Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> * fix: declare tf2 in tier4_dummy_object_rviz_plugin The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> --------- Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 7, 2026
…autowarefoundation#13209) * fix: declare the dependencies the simulator, e2e and map packages use Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> * fix: declare tf2 in tier4_dummy_object_rviz_plugin The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> --------- Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
shmpwk
pushed a commit
to tier4/pilot_auto_localization_map
that referenced
this pull request
Sep 11, 2026
…autowarefoundation/autoware_universe#13209) * fix: declare the dependencies the simulator, e2e and map packages use Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> * fix: declare tf2 in tier4_dummy_object_rviz_plugin The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> --------- Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
shmpwk
pushed a commit
to tier4/pilot_auto_simulation
that referenced
this pull request
Sep 14, 2026
…autowarefoundation/autoware_universe#13209) * fix: declare the dependencies the simulator, e2e and map packages use Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> * fix: declare tf2 in tier4_dummy_object_rviz_plugin The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> --------- Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
TetsuKawa
pushed a commit
to TetsuKawa/autoware_universe
that referenced
this pull request
Sep 15, 2026
…autowarefoundation#13209) * fix: declare the dependencies the simulator, e2e and map packages use Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> * fix: declare tf2 in tier4_dummy_object_rviz_plugin The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> --------- Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One package in each of the
simulator,e2eandmapcomponents uses headers or symbols of packages that it never declares. This adds the 13 missing<depend>entries.These packages build today only because another declared dependency re-exports the owner, or because some other package installs the system library.
The entries
Each entry links to the
package.xmlit goes into, and each example links to a line that uses the dependency, at the commit this branch starts from.tier4_dummy_object_rviz_plugin(simulator)autoware_perception_msgs<depend>car_pose.hpp:56using autoware_perception_msgs::msg::ObjectClassification;geometry_msgs<depend>interactive_object.cpp:77geometry_msgs::msg::Twistpluginlib<depend>car_pose.cpp:353#include <pluginlib/class_list_macros.hpp>rclcpp<depend>delete_all_objects.cpp:75rclcpp::Node::SharedPtrrviz_rendering<depend>util.cpp:18#include <rviz_rendering/render_window.hpp>tf2<depend>interactive_object.hpp:90tf2::Transform, andtf2::Quaternionininteractive_object.cppautoware_tensorrt_vad(e2e)eigen<depend>coordinate_transformer.cpp:29Eigen::Matrix4f, and#include <Eigen/...>in three more fileslibopencv-dev<depend>image_converter.cpp:17#include <opencv2/opencv.hpp>tf2<depend>coordinate_transformer.cpp:17#include <tf2/exceptions.h>tf2_msgs<depend>vad_node.cpp:155tf2_msgs::msg::TFMessageautoware_map_tf_generator(map)autoware_map_msgs<depend>vector_map_tf_generator_node.cpp:21#include <autoware_map_msgs/msg/lanelet_map_bin.hpp>geometry_msgs<depend>pcd_map_tf_generator_node.cpp:79geometry_msgs::msg::TransformStampedlanelet2_core<depend>vector_map_tf_generator_node.cpp:23#include <lanelet2_core/LaneletMap.h>AI usage
AI usage: written with Claude Code. The checker from the tracking issue produced the entries, and Claude Code verified each entry against its source lines and applied the edits.
Self-review: Looks good, checked manually 👍
Verification: every entry maps to a real use in the sources, and the three packages build cleanly with the new entries.
The checker run
On
mainat4260f35f2, in a jazzy workspace.fix_missing_deps.py --write, scoped tosimulator,e2eandmapin turn, reported one package per component and 12<depend>entries in total.tf2intier4_dummy_object_rviz_plugin. The code usestf2::Transformandtf2::Quaterniondirectly, while onlytf2_geometry_msgsandtf2_roswere declared.Per-entry source check
package.xmlbefore the edit.rosdep resolve eigen libopencv-devreturnedapt libeigen3-devandapt libopencv-dev.Build
colcon build --symlink-install --packages-select autoware_map_tf_generator tier4_dummy_object_rviz_plugin:Summary: 2 packages finished [56.1s], no errors.colcon build --symlink-install --packages-select autoware_tensorrt_vad:Summary: 1 package finished [7.56s]. Only the manifest changed, so this run reconfigures and recompiles nothing.tf2entry:colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-select tier4_dummy_object_rviz_plugin:Summary: 1 package finished [7.04s].FindFLANN.cmake.colcon test, and a build of the reverse-dependency closure. The repository CI builds the pull request.