Skip to content

fix: declare the dependencies the simulator, e2e and map packages use - #13209

Merged
xmfcx merged 2 commits into
autowarefoundation:mainfrom
xmfcx:fix/sim-e2e-map-missing-deps
Aug 17, 2026
Merged

xmfcx merged 2 commits into
autowarefoundation:mainfrom
xmfcx:fix/sim-e2e-map-missing-deps

Conversation

@xmfcx

@xmfcx xmfcx commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Description

One package in each of the simulator, e2e and map components uses headers or symbols of packages that it never declares. This adds the 13 missing <depend> entries.

These packages build today only because another declared dependency re-exports the owner, or because some other package installs the system library.

The entries

Each entry links to the package.xml it goes into, and each example links to a line that uses the dependency, at the commit this branch starts from.

tier4_dummy_object_rviz_plugin (simulator)

Entry Tag Example use
autoware_perception_msgs <depend> car_pose.hpp:56 using autoware_perception_msgs::msg::ObjectClassification;
geometry_msgs <depend> interactive_object.cpp:77 geometry_msgs::msg::Twist
pluginlib <depend> car_pose.cpp:353 #include <pluginlib/class_list_macros.hpp>
rclcpp <depend> delete_all_objects.cpp:75 rclcpp::Node::SharedPtr
rviz_rendering <depend> util.cpp:18 #include <rviz_rendering/render_window.hpp>
tf2 <depend> interactive_object.hpp:90 tf2::Transform, and tf2::Quaternion in interactive_object.cpp

autoware_tensorrt_vad (e2e)

Entry Tag Example use
eigen <depend> coordinate_transformer.cpp:29 Eigen::Matrix4f, and #include <Eigen/...> in three more files
libopencv-dev <depend> image_converter.cpp:17 #include <opencv2/opencv.hpp>
tf2 <depend> coordinate_transformer.cpp:17 #include <tf2/exceptions.h>
tf2_msgs <depend> vad_node.cpp:155 tf2_msgs::msg::TFMessage

autoware_map_tf_generator (map)

Entry Tag Example use
autoware_map_msgs <depend> vector_map_tf_generator_node.cpp:21 #include <autoware_map_msgs/msg/lanelet_map_bin.hpp>
geometry_msgs <depend> pcd_map_tf_generator_node.cpp:79 geometry_msgs::msg::TransformStamped
lanelet2_core <depend> vector_map_tf_generator_node.cpp:23 #include <lanelet2_core/LaneletMap.h>

AI usage

AI usage: written with Claude Code. The checker from the tracking issue produced the entries, and Claude Code verified each entry against its source lines and applied the edits.

Self-review: Looks good, checked manually 👍

Verification: every entry maps to a real use in the sources, and the three packages build cleanly with the new entries.

The checker run

On main at 4260f35f2, in a jazzy workspace.

  • fix_missing_deps.py --write, scoped to simulator, e2e and map in turn, reported one package per component and 12 <depend> entries in total.
  • A later review of the branch found one entry that the checker missed: tf2 in tier4_dummy_object_rviz_plugin. The code uses tf2::Transform and tf2::Quaternion directly, while only tf2_geometry_msgs and tf2_ros were declared.

Per-entry source check

  • Each of the 13 entries matched at least one source line in its package that includes or names the dependency. The tables above link one example per entry.
  • Each entry was absent from its package.xml before the edit.
  • rosdep resolve eigen libopencv-dev returned apt libeigen3-dev and apt libopencv-dev.

Build

  • colcon build --symlink-install --packages-select autoware_map_tf_generator tier4_dummy_object_rviz_plugin: Summary: 2 packages finished [56.1s], no errors.
  • colcon build --symlink-install --packages-select autoware_tensorrt_vad: Summary: 1 package finished [7.56s]. Only the manifest changed, so this run reconfigures and recompiles nothing.
  • After the tf2 entry: colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-select tier4_dummy_object_rviz_plugin: Summary: 1 package finished [7.04s].
  • The only stderr output is a pre-existing CMake dev warning from FindFLANN.cmake.
  • Not run: colcon test, and a build of the reverse-dependency closure. The repository CI builds the pull request.

Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx added type:bug Software flaws or errors. component:map Map creation, storage, and loading. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Aug 14, 2026
@xmfcx xmfcx self-assigned this Aug 14, 2026
@github-actions

Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 15, 2026
@xmfcx
xmfcx marked this pull request as ready for review August 15, 2026 07:55
@xmfcx
xmfcx requested a review from mitsudome-r August 15, 2026 07:56
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.35%. Comparing base (4260f35) to head (0c25a48).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13209      +/-   ##
==========================================
- Coverage   20.35%   20.35%   -0.01%     
==========================================
  Files        1946     1946              
  Lines      136634   136634              
  Branches    48746    48746              
==========================================
- Hits        27818    27817       -1     
  Misses      86282    86282              
- Partials    22534    22535       +1     
Flag Coverage Δ *Carryforward flag
daily ?
full-suite 20.35% <ø> (ø) Carriedforward from 4260f35

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xmfcx
xmfcx merged commit 1ab1534 into autowarefoundation:main Aug 17, 2026
47 of 48 checks passed
@github-project-automation github-project-automation Bot moved this from To Triage to Done in Software Working Group Aug 17, 2026
@xmfcx
xmfcx deleted the fix/sim-e2e-map-missing-deps branch August 17, 2026 05:16
TetsuKawa pushed a commit to TetsuKawa/autoware_universe that referenced this pull request Sep 7, 2026
…autowarefoundation#13209)

* fix: declare the dependencies the simulator, e2e and map packages use

Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

* fix: declare tf2 in tier4_dummy_object_rviz_plugin

The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

---------

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
TetsuKawa pushed a commit to TetsuKawa/autoware_universe that referenced this pull request Sep 7, 2026
…autowarefoundation#13209)

* fix: declare the dependencies the simulator, e2e and map packages use

Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

* fix: declare tf2 in tier4_dummy_object_rviz_plugin

The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

---------

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
shmpwk pushed a commit to tier4/pilot_auto_localization_map that referenced this pull request Sep 11, 2026
…autowarefoundation/autoware_universe#13209)

* fix: declare the dependencies the simulator, e2e and map packages use

Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

* fix: declare tf2 in tier4_dummy_object_rviz_plugin

The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

---------

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
shmpwk pushed a commit to tier4/pilot_auto_simulation that referenced this pull request Sep 14, 2026
…autowarefoundation/autoware_universe#13209)

* fix: declare the dependencies the simulator, e2e and map packages use

Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

* fix: declare tf2 in tier4_dummy_object_rviz_plugin

The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

---------

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
TetsuKawa pushed a commit to TetsuKawa/autoware_universe that referenced this pull request Sep 15, 2026
…autowarefoundation#13209)

* fix: declare the dependencies the simulator, e2e and map packages use

Three packages use headers or symbols of packages that they never declare. Add the 12 missing <depend> entries.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

* fix: declare tf2 in tier4_dummy_object_rviz_plugin

The plugin uses tf2::Transform and tf2::Quaternion directly, but only tf2_geometry_msgs and tf2_ros were declared.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

---------

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:map Map creation, storage, and loading. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:bug Software flaws or errors.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants