Skip to content

Comments

[release/9.5] Don't require gen_ai.system attribute on span events#11735

Merged
davidfowl merged 1 commit intorelease/9.5from
backport/pr-11733-to-release/9.5
Oct 1, 2025
Merged

[release/9.5] Don't require gen_ai.system attribute on span events#11735
davidfowl merged 1 commit intorelease/9.5from
backport/pr-11733-to-release/9.5

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 30, 2025 •
edited by JamesNK
Loading

Backport of #11733 to release/9.5

/cc @JamesNK

Customer Impact

User reported issue that some GenAI messages weren't displayed in the visualizer. The problem is the dashboard incorrectly requires gen_ai.system attribute to be on span events, but the spec says they're only recommended: https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/gen-ai/gen-ai-events.md#event-gen_aichoice

Semantic Kernel sometimes doesn't include the attribute. Its messages end up missing from the UI.

Removing the check for gen_ai.system is fine because we can still match on the event name to determine if a span event is AI related.

Testing

Unit tests

Risk

Low

Regression?

No

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 30, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11735

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11735"

@JamesNK JamesNK modified the milestones: 9.5, 9.5.1 Sep 30, 2025
@JamesNK JamesNK added the Servicing-consider Issue for next servicing release review label Sep 30, 2025
@joperezr joperezr added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 30, 2025
@joperezr
Copy link
Member

joperezr commented Sep 30, 2025

Customer reported, low risk. Approved.

@davidfowl davidfowl merged commit 90465ad into release/9.5 Oct 1, 2025
311 checks passed
This was referenced Oct 13, 2025
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 29, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
renebentes added a commit to renebentes/3054 that referenced this pull request Oct 30, 2025
@dependabot @renebentes
build(deps): Bump Microsoft.Extensions.ServiceDiscovery from 9.3.1 to…
eb4f13c 
… 9.5.2 (#53)

Updated
[Microsoft.Extensions.ServiceDiscovery](https://github.com/dotnet/aspire)
from 9.3.1 to 9.5.2.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.Extensions.ServiceDiscovery's
releases](https://github.com/dotnet/aspire/releases)._

## 9.5.2

## What's Changed
* [release/9.5] Revert SQL Server container image tag from 2025-latest
to 2022-latest for Mac ARM compatibility by @​github-actions[bot] in
dotnet/aspire#11908
* [release/9.5] Ensure OutputPath is created in
ResourceContainerImageBuilder by @​github-actions[bot] in
dotnet/aspire#11886
* [release/9.5] Add configuration to suppress unsecured telemetry
message in dashboard by @​github-actions[bot] in
dotnet/aspire#11954
* [release/9.5] Update dependencies from
https://github.com/microsoft/usvc-apiserver build 0.17.3 by @​danegsta
in dotnet/aspire#12032
* [release/9.5] Multi-target RabbitMQ and Redis client libraries by
@​eerhardt in dotnet/aspire#12138
* Backport PR #​11951: Add noProfileSwitch to run command in
DotNetCliRunner by @​Copilot in
dotnet/aspire#11959
* Bump patch version to 9.5.2 by @​Copilot in
dotnet/aspire#12139


**Full Changelog**:
dotnet/aspire@v9.5.1...v9.5.2

## 9.5.1

## What's Changed
* [release/9.5]: Add proper launch profile support to the VS Code
extension by @​Copilot in dotnet/aspire#11617
* [release/9.5] Cherry-pick extension build and sign pipeline setup by
@​Copilot in dotnet/aspire#11618
* [release/9.5] Fix globalPackagesFolder path to be platform-agnostic in
NuGetConfigMerger by @​github-actions[bot] in
dotnet/aspire#11626
* [release/9.5] Fix flashing console windows when Docker processes are
launched on Windows by @​github-actions[bot] in
dotnet/aspire#11615
* [release/9.5] Display help text for GenAI sensitive data when no
messages by @​github-actions[bot] in
dotnet/aspire#11668
* [release/9.5] Allow .NET 10 prerelease versions for single-file
apphost scenarios by @​github-actions[bot] in
dotnet/aspire#11616
* [release/9.5] Update Aspire package versions from 9.5.0 to 9.5.1 by
@​Copilot in dotnet/aspire#11721
* [release/9.5] Fix DevTunnels in DevContainers and Codespaces by
@​github-actions[bot] in dotnet/aspire#11730
* [release/9.5] Don't require gen_ai.system attribute on span events by
@​github-actions[bot] in dotnet/aspire#11735
* [release/9.5] Update Microsoft.Extensions.AI packages, use content env
var by @​github-actions[bot] in
dotnet/aspire#11726
* [release/9.5] Fix ParameterProcessor to use ExecutionContextOptions
and skip excluded resources by @​github-actions[bot] in
dotnet/aspire#11782
* [release/9.5] Update retry in Kusto emulator actions to handle any
non-permanent error by @​github-actions[bot] in
dotnet/aspire#11779
* [release/9.5] Fix CommandLineArgsCallbackContext ExecutionContext in
AzureResourcePreparer and prevent WithVSCodeDebugSupport execution in
publish mode by @​github-actions[bot] in
dotnet/aspire#11788
* [release/9.5] Fix GenAI visualizer when span is missing peer attribute
by @​JamesNK in dotnet/aspire#11765
* [release/9.5] Support parameter names with dashes resolved from
underscore configuration by @​github-actions[bot] in
dotnet/aspire#11802
* [release/9.5] Adapt OpenAI health check based on endpoint
configuration by @​github-actions[bot] in
dotnet/aspire#11792


**Full Changelog**:
dotnet/aspire@v9.5.0...v9.5.1

## 9.5.0

We are excited to share that our 9.5.0 release of Aspire has shipped!
All of the packages are available in NuGet.org now. Head over to
https://learn.microsoft.com/en-us/dotnet/aspire/whats-new/dotnet-aspire-9.5
to find what's new in 9.5.0!

## New Contributors
* @​benwitmanmsft made their first contribution in
dotnet/aspire#10289
* @​MattKotsenas made their first contribution in
dotnet/aspire#9868
* @​danespinosa made their first contribution in
dotnet/aspire#10394
* @​jnyrup made their first contribution in
dotnet/aspire#10884
* @​ericstj made their first contribution in
dotnet/aspire#10928
* @​jeremy-vm made their first contribution in
dotnet/aspire#10972
* @​Steinblock made their first contribution in
dotnet/aspire#11003
* @​brettcannon made their first contribution in
dotnet/aspire#11014
* @​twsouthwick made their first contribution in
dotnet/aspire#10507
* @​KirillOsenkov made their first contribution in
dotnet/aspire#11164
* @​CaitieM20 made their first contribution in
dotnet/aspire#10662

**Full Changelog**:
dotnet/aspire@v9.4.0...v9.5.0

## 9.4.2

## What's Changed
* [release/9.4] Simplify Aspire CLI project name validation to only
reject path separators by @​github-actions[bot] in
dotnet/aspire#10832
* [release/9.4] External Services with URL Parameter fails to generate
manifests by @​github-actions[bot] in
dotnet/aspire#10806
* [release/9.4] Always update resource list in console logs after hidden
bool changes by @​github-actions[bot] in
dotnet/aspire#10738
* [release/9.4] serve blazor.web.js from wwwroot by @​JamesNK in
dotnet/aspire#10990
* Branding updates for 9.4.2 by @​joperezr in
dotnet/aspire#11026
* [release/9.4] Port Fix creating projects with GB18030 chars by
@​danmoseley in dotnet/aspire#11032
* [release/9.4] Fix Azure AI Foundry resource name by
@​github-actions[bot] in dotnet/aspire#11038
* [release/9.4] Fixed properties override when publishing an update in
external service by @​github-actions[bot] in
dotnet/aspire#10824


**Full Changelog**:
dotnet/aspire@v9.4.1...v9.4.2

## 9.4.1

## What's Changed
* [release/9.4] Mark Aspire.CLI as stable by @​joperezr in
dotnet/aspire#10724
* [release/9.4] aspire config set writes appHostPath to
~/.aspire/settings.json globally, causing incorrect path resolution by
@​github-actions[bot] in dotnet/aspire#10703
* [release/9.4] Update dependencies from microsoft/usvc-apiserver by
@​danegsta in dotnet/aspire#10814
* [release/9.4] Fix grid scrolling bugs by @​github-actions[bot] in
dotnet/aspire#10861
* Bump package versions to 9.4.1 in project files by @​joperezr in
dotnet/aspire#10891


**Full Changelog**:
dotnet/aspire@v9.4.0...v9.4.1

## 9.4.0

We are excited to share that our 9.4.0 release of Aspire has shipped!
All of the packages are available in NuGet.org now. Head over to
https://learn.microsoft.com/en-us/dotnet/aspire/whats-new/dotnet-aspire-9.4
to find what's new in 9.4.0!

## What's Changed
* API review: Add Services property to ResourceEndpointsAllocatedEvent
by @​DamianEdwards in dotnet/aspire#9270
* Fix visibility updates during resource upserts by @​adamint in
dotnet/aspire#9264
* Accept null value in Redis WithPassword to ensure password dosen't set
in redis-server by @​Alirexaa in
dotnet/aspire#9278
* Make sure the publisher example supports azd by @​davidfowl in
dotnet/aspire#9277
* API review: `WithHostPort` should accept null for port param by
@​Alirexaa in dotnet/aspire#9282
* Refactor database explorer resource builders to not prefix their names
the name of the first resource they are added to. by @​paulomorgado in
dotnet/aspire#8237
* Test that ensures legacy dashboard token env var is honored by
@​DamianEdwards in dotnet/aspire#9296
* Refactor solution file from .sln to .slnx format and update related d…
by @​davidfowl in dotnet/aspire#9295
* Minor dashboard improvements and clean up by @​JamesNK in
dotnet/aspire#9301
* Minor improvements to resource changed log by @​JamesNK in
dotnet/aspire#9303
* Fix Blazor error logging to telemetry by @​JamesNK in
dotnet/aspire#9304
* Don't throw from component telemetry context dispose if not
initialized by @​JamesNK in dotnet/aspire#9306
* [CI] Add PR validation on macOS by @​radical in
dotnet/aspire#9287
* Localized file check-in by OneLocBuild Task: Build definition ID 1309:
Build ID 2709142 by @​dotnet-bot in
dotnet/aspire#9302
* Ignore case on FormatDateTime_WithMilliseconds_NewZealandCulture by
@​adamint in dotnet/aspire#9316
* Changing default SKU for App Service Plan to P0V3 by @​ShilpiRachna1
in dotnet/aspire#9280
* Branding updates for 9.4 by @​joperezr in
dotnet/aspire#9331
* Increase retry time in AppBar_Change_Theme_ReloadPage by @​adamint in
dotnet/aspire#9317
* Update xUnit.v3 to support MTP tests by @​peterwald in
dotnet/aspire#9261
* [main] Update dependencies from microsoft/usvc-apiserver by
@​dotnet-maestro[bot] in dotnet/aspire#9333
* Add tracing support for Azure App Configuration component by
@​zhiyuanliang-ms in dotnet/aspire#9323
* Revert "Update xUnit.v3 to support MTP tests (#​9261)" by @​radical in
dotnet/aspire#9336
* Remove the workaround to explicitly set the container runtime for
tests now that the orchestrator is updated by @​danegsta in
dotnet/aspire#9339
* [Automated] Update API Surface Area by @​github-actions[bot] in
dotnet/aspire#8736
* Revert "Revert "Update xUnit.v3 to support MTP tests (#​9261)"
(#​9336)" by @​radical in dotnet/aspire#9337
* TestsReportGenerator: Always show the error message, and truncate only
the stdout by @​radical in dotnet/aspire#9335
* [CI] Fix azdo builds for `main` by @​radical in
dotnet/aspire#9338
* [main] Update dependencies from microsoft/usvc-apiserver by
@​dotnet-maestro[bot] in dotnet/aspire#9347
* Fully qualify OutputPath for PublishingContext by @​captainsafia in
dotnet/aspire#9351
* Fix typo in doccomment in `ContainerResourceBuilderExtensions.cs` by
@​KuraiAndras in dotnet/aspire#9342
* Update health check to ensure blob containers created at right time by
@​RussKie in dotnet/aspire#9159
* Re-apply quarantined test for validation by @​sebastienros in
dotnet/aspire#9364
* Update telemetry doc for AzureAppConfiguration by @​sebastienros in
dotnet/aspire#9365
* Enable MTP tests via MSBuild property by @​captainsafia in
dotnet/aspire#9361
* catch json error by @​danmoseley in
dotnet/aspire#9369
* Refactor a common TempDirectory test class by @​eerhardt in
dotnet/aspire#9370
* Centralize Verify convention by @​sebastienros in
dotnet/aspire#9371
* Update Aspire to stable Microsoft.Extensions.AI.Abstractions by
@​stephentoub in dotnet/aspire#9356
* Update RunCommand.cs by @​IEvangelist in
dotnet/aspire#9360
* Add support for copying existing files via WithContainerFiles API by
@​danegsta in dotnet/aspire#8908
* Do not fail on partial trust warning. by @​mitchdenny in
dotnet/aspire#9384
* markdown lint by @​danmoseley in
dotnet/aspire#9389
* Merge branch release/9.3 into main by @​joperezr in
dotnet/aspire#9394
* Fix failure in MongoDbFunctionalTests.VerifyWithInitFiles by
@​danegsta in dotnet/aspire#9391
* Ensure all grid columns have tooltips by @​adamint in
dotnet/aspire#9401
* Remove test from quarantine by @​danegsta in
dotnet/aspire#9402
* copilot setup steps by @​danmoseley in
dotnet/aspire#9409
 ... (truncated)

## 9.3.2

## What's Changed
* [release/9.3] Fix SqlServer PowerShell module version to avoid
breaking changes in 22.4.5.1 by @​sebastienros in
dotnet/aspire#9958
* Bumping patch version for 9.3.2 by @​joperezr in
dotnet/aspire#9963


**Full Changelog**:
dotnet/aspire@v9.3.1...v9.3.2

Commits viewable in [compare
view](dotnet/aspire@v9.3.1...v9.5.2).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.Extensions.ServiceDiscovery&package-manager=nuget&previous-version=9.3.1&new-version=9.5.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rene Bentes Pinto <renebentes@yahoo.com.br>
This was referenced Oct 31, 2025
Open
Open
Closed
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
@sebastienros sebastienros deleted the backport/pr-11733-to-release/9.5 branch January 15, 2026 23:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidfowl davidfowl davidfowl approved these changes

@joperezr joperezr joperezr approved these changes

Assignees

No one assigned

Labels

area-dashboard Re-opened Github-Action PR Servicing-approved Approved for servicing release

Projects

None yet

Milestone

9.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@joperezr @davidfowl @JamesNK