Repository navigation
Improve index inference diagnostics - #165979
Merged
rust-bors[bot] merged 1 commit intoNov 16, 2026
Merged
rust-bors[bot] merged 1 commit into
rust-bors[bot] merged 1 commit into
Conversation
pkondzior
force-pushed
the
fix-105329-index-inference-diagnostics
branch
from
November 14, 2026 23:13
7fa58e9 to
71e6103
Compare
Contributor
|
@bors r+ |
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 16, 2026
…ce-diagnostics, r=estebank Improve index inference diagnostics Addresses 1. from rust-lang#105329 > I propose to improve the error message so that it points to the part f(s) specifically, and even better to also tell the user to specify the type of f, even though the compiler might not be able to tell what it should be. <img width="875" height="625" alt="Screenshot 2026-11-14 at 22 23 19" src="https://github.com/user-attachments/assets/b331e066-fe4b-44a6-b142-4a11bbe5e433" /> r? @estebank
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 16, 2026
…ce-diagnostics, r=estebank Improve index inference diagnostics Addresses 1. from rust-lang#105329 > I propose to improve the error message so that it points to the part f(s) specifically, and even better to also tell the user to specify the type of f, even though the compiler might not be able to tell what it should be. <img width="875" height="625" alt="Screenshot 2026-11-14 at 22 23 19" src="https://github.com/user-attachments/assets/b331e066-fe4b-44a6-b142-4a11bbe5e433" /> r? @estebank
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 16, 2026
…ce-diagnostics, r=estebank Improve index inference diagnostics Addresses 1. from rust-lang#105329 > I propose to improve the error message so that it points to the part f(s) specifically, and even better to also tell the user to specify the type of f, even though the compiler might not be able to tell what it should be. <img width="875" height="625" alt="Screenshot 2026-11-14 at 22 23 19" src="https://github.com/user-attachments/assets/b331e066-fe4b-44a6-b142-4a11bbe5e433" /> r? @estebank
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 16, 2026
…ce-diagnostics, r=estebank Improve index inference diagnostics Addresses 1. from rust-lang#105329 > I propose to improve the error message so that it points to the part f(s) specifically, and even better to also tell the user to specify the type of f, even though the compiler might not be able to tell what it should be. <img width="875" height="625" alt="Screenshot 2026-11-14 at 22 23 19" src="https://github.com/user-attachments/assets/b331e066-fe4b-44a6-b142-4a11bbe5e433" /> r? @estebank
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 16, 2026
…ce-diagnostics, r=estebank Improve index inference diagnostics Addresses 1. from rust-lang#105329 > I propose to improve the error message so that it points to the part f(s) specifically, and even better to also tell the user to specify the type of f, even though the compiler might not be able to tell what it should be. <img width="875" height="625" alt="Screenshot 2026-11-14 at 22 23 19" src="https://github.com/user-attachments/assets/b331e066-fe4b-44a6-b142-4a11bbe5e433" /> r? @estebank
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 16, 2026
…uwer Rollup of 24 pull requests Successful merges: - #165819 (Avoid redundant scans when extracting stage0 archives) - #166011 (Clean revert of recent `String::retain` changes) - #159805 (Implemented different with_native_path conversion methods, refactoring fs functions to utilize with_native_path, and move exists to use with_native_path) - #162414 (Make min/max and copysign intrinsics generic) - #163891 (Do not include context span when source is unavailable to render) - #164156 (Improve collapsed suggestions for trait impls tuples) - #165900 ([tiny] Tweak wording of missing `core` note) - #165978 (Mention `#![doc = include_str!(...)]` trick in intro page) - #165979 (Improve index inference diagnostics) - #165983 (Update `minifier-rs` dependency version to `0.5.0`) - #165999 (Update TPDE submodule) - #166005 (add ABI compat checks for new float types) - #165406 (Do not suggest `as_deref` for a slice pattern on `Err`) - #165792 (prevent optimization for input in ascii benchmarks) - #165936 (Enhance documentation for try_clone File implementation) - #165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`) - #165941 (Merge `type_bf16()` with `type_f16b()`) - #165942 (windows: use io::const_error in get_access_mode) - #165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor) - #165956 (Document wide pointers in core::ptr module) - #165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset) - #165993 (pipe_subprocess test: use libtest harness) - #165996 (Fix(docs): Correct discard behavior in datagram peek docs) - #165998 (Cleanup borrowck)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 16, 2026
…ce-diagnostics, r=estebank Improve index inference diagnostics Addresses 1. from rust-lang#105329 > I propose to improve the error message so that it points to the part f(s) specifically, and even better to also tell the user to specify the type of f, even though the compiler might not be able to tell what it should be. <img width="875" height="625" alt="Screenshot 2026-11-14 at 22 23 19" src="https://github.com/user-attachments/assets/b331e066-fe4b-44a6-b142-4a11bbe5e433" /> r? @estebank
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 16, 2026
…ce-diagnostics, r=estebank Improve index inference diagnostics Addresses 1. from rust-lang#105329 > I propose to improve the error message so that it points to the part f(s) specifically, and even better to also tell the user to specify the type of f, even though the compiler might not be able to tell what it should be. <img width="875" height="625" alt="Screenshot 2026-11-14 at 22 23 19" src="https://github.com/user-attachments/assets/b331e066-fe4b-44a6-b142-4a11bbe5e433" /> r? @estebank
This was referenced Nov 16, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 16, 2026
…uwer Rollup of 21 pull requests Successful merges: - #166011 (Clean revert of recent `String::retain` changes) - #165475 (Add a `!type` annotation to a vtable for every supertrait that is a prefix of the vtable) - #165881 (fix MSVC calling convention byte counts) - #165882 (Add a separate feature gate for EIIs with default impls) - #165922 (Prevent inlining of foreign items through glob reexports named `_`) - #165979 (Improve index inference diagnostics) - #165983 (Update `minifier-rs` dependency version to `0.5.0`) - #165613 (Handle trait default values in `mir_for_direct_const`) - #165677 (Rewrite relaxed bound policy code) - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes) - #165990 (gca fixed issue regression tests) - #165993 (pipe_subprocess test: use libtest harness) - #165998 (Cleanup borrowck) - #166005 (add ABI compat checks for new float types) - #166009 (Improve `String::insert{,_str}` safety comments) - #166021 (Correct and expand E0225 error explanation.) - #166029 (rustc-dev-guide subtree update) - #166031 (Split packed structs out of `const_struct`) - #166032 (Normalize the simd field type before reading its length) - #166034 (Three LLVM-type-related cleanups) - #166047 (Document AltiVec requirement for powerpc64-unknown-linux-gnuelfv2)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 16, 2026
Rollup merge of #165979 - pkondzior:fix-105329-index-inference-diagnostics, r=estebank Improve index inference diagnostics Addresses 1. from #105329 > I propose to improve the error message so that it points to the part f(s) specifically, and even better to also tell the user to specify the type of f, even though the compiler might not be able to tell what it should be. <img width="875" height="625" alt="Screenshot 2026-11-14 at 22 23 19" src="https://github.com/user-attachments/assets/b331e066-fe4b-44a6-b142-4a11bbe5e433" /> r? @estebank
sushink70
pushed a commit
to sushink70/miri
that referenced
this pull request
Nov 17, 2026
…uwer Rollup of 21 pull requests Successful merges: - rust-lang/rust#166011 (Clean revert of recent `String::retain` changes) - rust-lang/rust#165475 (Add a `!type` annotation to a vtable for every supertrait that is a prefix of the vtable) - rust-lang/rust#165881 (fix MSVC calling convention byte counts) - rust-lang/rust#165882 (Add a separate feature gate for EIIs with default impls) - rust-lang/rust#165922 (Prevent inlining of foreign items through glob reexports named `_`) - rust-lang/rust#165979 (Improve index inference diagnostics) - rust-lang/rust#165983 (Update `minifier-rs` dependency version to `0.5.0`) - rust-lang/rust#165613 (Handle trait default values in `mir_for_direct_const`) - rust-lang/rust#165677 (Rewrite relaxed bound policy code) - rust-lang/rust#165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes) - rust-lang/rust#165990 (gca fixed issue regression tests) - rust-lang/rust#165993 (pipe_subprocess test: use libtest harness) - rust-lang/rust#165998 (Cleanup borrowck) - rust-lang/rust#166005 (add ABI compat checks for new float types) - rust-lang/rust#166009 (Improve `String::insert{,_str}` safety comments) - rust-lang/rust#166021 (Correct and expand E0225 error explanation.) - rust-lang/rust#166029 (rustc-dev-guide subtree update) - rust-lang/rust#166031 (Split packed structs out of `const_struct`) - rust-lang/rust#166032 (Normalize the simd field type before reading its length) - rust-lang/rust#166034 (Three LLVM-type-related cleanups) - rust-lang/rust#166047 (Document AltiVec requirement for powerpc64-unknown-linux-gnuelfv2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 1. from #105329
r? @estebank