Skip to content

Normalize the simd field type before reading its length - #166032

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
bit-aloo:2026-11-15-simd-layout-error-const-len-ice
Nov 16, 2026
Merged

rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
bit-aloo:2026-11-15-simd-layout-error-const-len-ice

Conversation

@bit-aloo

@bit-aloo bit-aloo commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

The simd branch in layout_of_uncached was assuming the field type was already normalized, but field.ty(tcx, args) only substitutes generic arguments. So, we now normalize the field type before extracting the array length. Initially we use to normalize it, but we removed it in: #137852 (might be an oversight?)

closes: #138009

r? @khyperia

@rustbot

rustbot commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 16, 2026
@rustbot

rustbot commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

khyperia is currently at their maximum review capacity.
They may take a while to respond.

@khyperia

Copy link
Copy Markdown
Member

skip_norm_wip being called where we should actually be normalizing, indicating a bug?? say it ain't so. thanks ❤️

@bors r+ rollup

@rust-bors

rust-bors Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 51b5faf has been approved by khyperia

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…ror-const-len-ice, r=khyperia

Normalize the simd field type before reading its length

The simd branch in layout_of_uncached was assuming the field type was already normalized, but field.ty(tcx, args) only substitutes generic arguments. So, we now normalize the field type before extracting the array length. Initially we use to normalize it, but we removed it in: rust-lang#137852 (might be an oversight?)

closes: rust-lang#138009

r? @khyperia
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 21 pull requests

Successful merges:

 - #166011 (Clean revert of recent `String::retain` changes)
 - #165475 (Add a `!type` annotation to a vtable for every supertrait that is a prefix of the vtable)
 - #165881 (fix MSVC calling convention byte counts)
 - #165882 (Add a separate feature gate for EIIs with default impls)
 - #165922 (Prevent inlining of foreign items through glob reexports named `_`)
 - #165979 (Improve index inference diagnostics)
 - #165983 (Update `minifier-rs` dependency version to `0.5.0`)
 - #165613 (Handle trait default values in `mir_for_direct_const`)
 - #165677 (Rewrite relaxed bound policy code)
 - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes)
 - #165990 (gca fixed issue regression tests)
 - #165993 (pipe_subprocess test: use libtest harness)
 - #165998 (Cleanup borrowck)
 - #166005 (add ABI compat checks for new float types)
 - #166009 (Improve `String::insert{,_str}` safety comments)
 - #166021 (Correct and expand E0225 error explanation.)
 - #166029 (rustc-dev-guide subtree update)
 - #166031 (Split packed structs out of `const_struct`)
 - #166032 (Normalize the simd field type before reading its length)
 - #166034 (Three LLVM-type-related cleanups)
 - #166047 (Document AltiVec requirement for powerpc64-unknown-linux-gnuelfv2)
@rust-bors
rust-bors Bot merged commit ac30f1d into rust-lang:main Nov 16, 2026
14 checks passed
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
Rollup merge of #166032 - bit-aloo:2026-11-15-simd-layout-error-const-len-ice, r=khyperia

Normalize the simd field type before reading its length

The simd branch in layout_of_uncached was assuming the field type was already normalized, but field.ty(tcx, args) only substitutes generic arguments. So, we now normalize the field type before extracting the array length. Initially we use to normalize it, but we removed it in: #137852 (might be an oversight?)

closes: #138009

r? @khyperia
@rustbot rustbot added this to the 1.102.0 milestone Nov 16, 2026
@bit-aloo
bit-aloo deleted the 2026-11-15-simd-layout-error-const-len-ice branch November 17, 2026 01:48
sushink70 pushed a commit to sushink70/miri that referenced this pull request Nov 17, 2026
…uwer

Rollup of 21 pull requests

Successful merges:

 - rust-lang/rust#166011 (Clean revert of recent `String::retain` changes)
 - rust-lang/rust#165475 (Add a `!type` annotation to a vtable for every supertrait that is a prefix of the vtable)
 - rust-lang/rust#165881 (fix MSVC calling convention byte counts)
 - rust-lang/rust#165882 (Add a separate feature gate for EIIs with default impls)
 - rust-lang/rust#165922 (Prevent inlining of foreign items through glob reexports named `_`)
 - rust-lang/rust#165979 (Improve index inference diagnostics)
 - rust-lang/rust#165983 (Update `minifier-rs` dependency version to `0.5.0`)
 - rust-lang/rust#165613 (Handle trait default values in `mir_for_direct_const`)
 - rust-lang/rust#165677 (Rewrite relaxed bound policy code)
 - rust-lang/rust#165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes)
 - rust-lang/rust#165990 (gca fixed issue regression tests)
 - rust-lang/rust#165993 (pipe_subprocess test: use libtest harness)
 - rust-lang/rust#165998 (Cleanup borrowck)
 - rust-lang/rust#166005 (add ABI compat checks for new float types)
 - rust-lang/rust#166009 (Improve `String::insert{,_str}` safety comments)
 - rust-lang/rust#166021 (Correct and expand E0225 error explanation.)
 - rust-lang/rust#166029 (rustc-dev-guide subtree update)
 - rust-lang/rust#166031 (Split packed structs out of `const_struct`)
 - rust-lang/rust#166032 (Normalize the simd field type before reading its length)
 - rust-lang/rust#166034 (Three LLVM-type-related cleanups)
 - rust-lang/rust#166047 (Document AltiVec requirement for powerpc64-unknown-linux-gnuelfv2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: layout_of: unexpected const: {const error}

3 participants