Repository navigation
add ABI compat checks for new float types - #166005
Conversation
|
cc @rust-lang/miri |
There was a problem hiding this comment.
Miri tests do not run on powerpc so I didn't bother adding ppcf128 here.
By the looks of it |
Ah right -- I thought it was 3 types, just didn't remember the third... |
| )] | ||
| pub use core::num::ZeroablePrimitive; | ||
| #[unstable(feature = "f16b", issue = "160630")] | ||
| pub use core::num::f16b; |
There was a problem hiding this comment.
I assume it is an accident that f16b existed in core::num but not in std::num.
Cc @rust-lang/libs-ping
There was a problem hiding this comment.
I'd say so, it's a bit subtle that you need to add it to both.
858e49c to
ec2be6c
Compare
This comment has been minimized.
This comment has been minimized.
|
LGTM, r=me if it passes CI. Also, I think the new float types ought to support |
|
Yes, the initial PR for landing the type(s) kept that out but we fully intend to support |
|
I actually kind of prefer not having the trait bound. @bors r=joshtriplett (Btw if you say |
add ABI compat checks for new float types These types are quite special ABI-wise, let's make sure they are covered here as well. r? @folkertdev Are there any float types I missed?
add ABI compat checks for new float types These types are quite special ABI-wise, let's make sure they are covered here as well. r? @folkertdev Are there any float types I missed?
add ABI compat checks for new float types These types are quite special ABI-wise, let's make sure they are covered here as well. r? @folkertdev Are there any float types I missed?
add ABI compat checks for new float types These types are quite special ABI-wise, let's make sure they are covered here as well. r? @folkertdev Are there any float types I missed?
add ABI compat checks for new float types These types are quite special ABI-wise, let's make sure they are covered here as well. r? @folkertdev Are there any float types I missed?
…uwer Rollup of 24 pull requests Successful merges: - #165819 (Avoid redundant scans when extracting stage0 archives) - #166011 (Clean revert of recent `String::retain` changes) - #159805 (Implemented different with_native_path conversion methods, refactoring fs functions to utilize with_native_path, and move exists to use with_native_path) - #162414 (Make min/max and copysign intrinsics generic) - #163891 (Do not include context span when source is unavailable to render) - #164156 (Improve collapsed suggestions for trait impls tuples) - #165900 ([tiny] Tweak wording of missing `core` note) - #165978 (Mention `#![doc = include_str!(...)]` trick in intro page) - #165979 (Improve index inference diagnostics) - #165983 (Update `minifier-rs` dependency version to `0.5.0`) - #165999 (Update TPDE submodule) - #166005 (add ABI compat checks for new float types) - #165406 (Do not suggest `as_deref` for a slice pattern on `Err`) - #165792 (prevent optimization for input in ascii benchmarks) - #165936 (Enhance documentation for try_clone File implementation) - #165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`) - #165941 (Merge `type_bf16()` with `type_f16b()`) - #165942 (windows: use io::const_error in get_access_mode) - #165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor) - #165956 (Document wide pointers in core::ptr module) - #165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset) - #165993 (pipe_subprocess test: use libtest harness) - #165996 (Fix(docs): Correct discard behavior in datagram peek docs) - #165998 (Cleanup borrowck)
add ABI compat checks for new float types These types are quite special ABI-wise, let's make sure they are covered here as well. r? @folkertdev Are there any float types I missed?
add ABI compat checks for new float types These types are quite special ABI-wise, let's make sure they are covered here as well. r? @folkertdev Are there any float types I missed?
|
@bors rollup+ |
|
Unknown command "rollup+". Run |
|
@bors rollup |
…uwer Rollup of 21 pull requests Successful merges: - #166011 (Clean revert of recent `String::retain` changes) - #165475 (Add a `!type` annotation to a vtable for every supertrait that is a prefix of the vtable) - #165881 (fix MSVC calling convention byte counts) - #165882 (Add a separate feature gate for EIIs with default impls) - #165922 (Prevent inlining of foreign items through glob reexports named `_`) - #165979 (Improve index inference diagnostics) - #165983 (Update `minifier-rs` dependency version to `0.5.0`) - #165613 (Handle trait default values in `mir_for_direct_const`) - #165677 (Rewrite relaxed bound policy code) - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes) - #165990 (gca fixed issue regression tests) - #165993 (pipe_subprocess test: use libtest harness) - #165998 (Cleanup borrowck) - #166005 (add ABI compat checks for new float types) - #166009 (Improve `String::insert{,_str}` safety comments) - #166021 (Correct and expand E0225 error explanation.) - #166029 (rustc-dev-guide subtree update) - #166031 (Split packed structs out of `const_struct`) - #166032 (Normalize the simd field type before reading its length) - #166034 (Three LLVM-type-related cleanups) - #166047 (Document AltiVec requirement for powerpc64-unknown-linux-gnuelfv2)
Rollup merge of #166005 - RalfJung:float-abi, r=joshtriplett add ABI compat checks for new float types These types are quite special ABI-wise, let's make sure they are covered here as well. r? @folkertdev Are there any float types I missed?
…uwer Rollup of 21 pull requests Successful merges: - rust-lang/rust#166011 (Clean revert of recent `String::retain` changes) - rust-lang/rust#165475 (Add a `!type` annotation to a vtable for every supertrait that is a prefix of the vtable) - rust-lang/rust#165881 (fix MSVC calling convention byte counts) - rust-lang/rust#165882 (Add a separate feature gate for EIIs with default impls) - rust-lang/rust#165922 (Prevent inlining of foreign items through glob reexports named `_`) - rust-lang/rust#165979 (Improve index inference diagnostics) - rust-lang/rust#165983 (Update `minifier-rs` dependency version to `0.5.0`) - rust-lang/rust#165613 (Handle trait default values in `mir_for_direct_const`) - rust-lang/rust#165677 (Rewrite relaxed bound policy code) - rust-lang/rust#165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes) - rust-lang/rust#165990 (gca fixed issue regression tests) - rust-lang/rust#165993 (pipe_subprocess test: use libtest harness) - rust-lang/rust#165998 (Cleanup borrowck) - rust-lang/rust#166005 (add ABI compat checks for new float types) - rust-lang/rust#166009 (Improve `String::insert{,_str}` safety comments) - rust-lang/rust#166021 (Correct and expand E0225 error explanation.) - rust-lang/rust#166029 (rustc-dev-guide subtree update) - rust-lang/rust#166031 (Split packed structs out of `const_struct`) - rust-lang/rust#166032 (Normalize the simd field type before reading its length) - rust-lang/rust#166034 (Three LLVM-type-related cleanups) - rust-lang/rust#166047 (Document AltiVec requirement for powerpc64-unknown-linux-gnuelfv2)
These types are quite special ABI-wise, let's make sure they are covered here as well.
r? @folkertdev
Are there any float types I missed?