Repository navigation
Improve String::insert{,_str} safety comments - #166009
Merged
Merged
Conversation
Collaborator
|
|
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @thomcc (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. |
Member
|
@bors r+ rollup |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 16, 2026
Improve `String::insert{,_str}` safety comments
These comments were wrongly annotated with SAFETY despite mostly being regular comments.
Now the SAFETY tag only applies to the actual safety considerations, some of which I've added.
r? @thomcc
This was referenced Nov 16, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 16, 2026
…uwer Rollup of 21 pull requests Successful merges: - #166011 (Clean revert of recent `String::retain` changes) - #165475 (Add a `!type` annotation to a vtable for every supertrait that is a prefix of the vtable) - #165881 (fix MSVC calling convention byte counts) - #165882 (Add a separate feature gate for EIIs with default impls) - #165922 (Prevent inlining of foreign items through glob reexports named `_`) - #165979 (Improve index inference diagnostics) - #165983 (Update `minifier-rs` dependency version to `0.5.0`) - #165613 (Handle trait default values in `mir_for_direct_const`) - #165677 (Rewrite relaxed bound policy code) - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes) - #165990 (gca fixed issue regression tests) - #165993 (pipe_subprocess test: use libtest harness) - #165998 (Cleanup borrowck) - #166005 (add ABI compat checks for new float types) - #166009 (Improve `String::insert{,_str}` safety comments) - #166021 (Correct and expand E0225 error explanation.) - #166029 (rustc-dev-guide subtree update) - #166031 (Split packed structs out of `const_struct`) - #166032 (Normalize the simd field type before reading its length) - #166034 (Three LLVM-type-related cleanups) - #166047 (Document AltiVec requirement for powerpc64-unknown-linux-gnuelfv2)
sushink70
pushed a commit
to sushink70/miri
that referenced
this pull request
Nov 17, 2026
…uwer Rollup of 21 pull requests Successful merges: - rust-lang/rust#166011 (Clean revert of recent `String::retain` changes) - rust-lang/rust#165475 (Add a `!type` annotation to a vtable for every supertrait that is a prefix of the vtable) - rust-lang/rust#165881 (fix MSVC calling convention byte counts) - rust-lang/rust#165882 (Add a separate feature gate for EIIs with default impls) - rust-lang/rust#165922 (Prevent inlining of foreign items through glob reexports named `_`) - rust-lang/rust#165979 (Improve index inference diagnostics) - rust-lang/rust#165983 (Update `minifier-rs` dependency version to `0.5.0`) - rust-lang/rust#165613 (Handle trait default values in `mir_for_direct_const`) - rust-lang/rust#165677 (Rewrite relaxed bound policy code) - rust-lang/rust#165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes) - rust-lang/rust#165990 (gca fixed issue regression tests) - rust-lang/rust#165993 (pipe_subprocess test: use libtest harness) - rust-lang/rust#165998 (Cleanup borrowck) - rust-lang/rust#166005 (add ABI compat checks for new float types) - rust-lang/rust#166009 (Improve `String::insert{,_str}` safety comments) - rust-lang/rust#166021 (Correct and expand E0225 error explanation.) - rust-lang/rust#166029 (rustc-dev-guide subtree update) - rust-lang/rust#166031 (Split packed structs out of `const_struct`) - rust-lang/rust#166032 (Normalize the simd field type before reading its length) - rust-lang/rust#166034 (Three LLVM-type-related cleanups) - rust-lang/rust#166047 (Document AltiVec requirement for powerpc64-unknown-linux-gnuelfv2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These comments were wrongly annotated with SAFETY despite mostly being regular comments.
Now the SAFETY tag only applies to the actual safety considerations, some of which I've added.
r? @thomcc