Skip to content

Improve String::insert{,_str} safety comments - #166009

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
T0mstone:main
Nov 16, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
T0mstone:main

Conversation

@T0mstone

Copy link
Copy Markdown
Contributor

These comments were wrongly annotated with SAFETY despite mostly being regular comments.
Now the SAFETY tag only applies to the actual safety considerations, some of which I've added.

r? @thomcc

@rustbot rustbot added A-str Area: `str` and `String` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 15, 2026
@rustbot

rustbot commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator

thomcc is currently at their maximum review capacity.
They may take a while to respond.

@rustbot

rustbot commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @thomcc (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

@thomcc

thomcc commented Nov 15, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0d6d542 has been tentatively approved by thomcc

It will be put into the queue for this repository once PR CI succeeds.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
Improve `String::insert{,_str}` safety comments

These comments were wrongly annotated with SAFETY despite mostly being regular comments.
Now the SAFETY tag only applies to the actual safety considerations, some of which I've added.

r? @thomcc
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 21 pull requests

Successful merges:

 - #166011 (Clean revert of recent `String::retain` changes)
 - #165475 (Add a `!type` annotation to a vtable for every supertrait that is a prefix of the vtable)
 - #165881 (fix MSVC calling convention byte counts)
 - #165882 (Add a separate feature gate for EIIs with default impls)
 - #165922 (Prevent inlining of foreign items through glob reexports named `_`)
 - #165979 (Improve index inference diagnostics)
 - #165983 (Update `minifier-rs` dependency version to `0.5.0`)
 - #165613 (Handle trait default values in `mir_for_direct_const`)
 - #165677 (Rewrite relaxed bound policy code)
 - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes)
 - #165990 (gca fixed issue regression tests)
 - #165993 (pipe_subprocess test: use libtest harness)
 - #165998 (Cleanup borrowck)
 - #166005 (add ABI compat checks for new float types)
 - #166009 (Improve `String::insert{,_str}` safety comments)
 - #166021 (Correct and expand E0225 error explanation.)
 - #166029 (rustc-dev-guide subtree update)
 - #166031 (Split packed structs out of `const_struct`)
 - #166032 (Normalize the simd field type before reading its length)
 - #166034 (Three LLVM-type-related cleanups)
 - #166047 (Document AltiVec requirement for powerpc64-unknown-linux-gnuelfv2)
@rust-bors
rust-bors Bot merged commit e2b4c61 into rust-lang:main Nov 16, 2026
14 checks passed
@rustbot rustbot added this to the 1.102.0 milestone Nov 16, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
Rollup merge of #166009 - T0mstone:main, r=thomcc

Improve `String::insert{,_str}` safety comments

These comments were wrongly annotated with SAFETY despite mostly being regular comments.
Now the SAFETY tag only applies to the actual safety considerations, some of which I've added.

r? @thomcc
sushink70 pushed a commit to sushink70/miri that referenced this pull request Nov 17, 2026
…uwer

Rollup of 21 pull requests

Successful merges:

 - rust-lang/rust#166011 (Clean revert of recent `String::retain` changes)
 - rust-lang/rust#165475 (Add a `!type` annotation to a vtable for every supertrait that is a prefix of the vtable)
 - rust-lang/rust#165881 (fix MSVC calling convention byte counts)
 - rust-lang/rust#165882 (Add a separate feature gate for EIIs with default impls)
 - rust-lang/rust#165922 (Prevent inlining of foreign items through glob reexports named `_`)
 - rust-lang/rust#165979 (Improve index inference diagnostics)
 - rust-lang/rust#165983 (Update `minifier-rs` dependency version to `0.5.0`)
 - rust-lang/rust#165613 (Handle trait default values in `mir_for_direct_const`)
 - rust-lang/rust#165677 (Rewrite relaxed bound policy code)
 - rust-lang/rust#165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes)
 - rust-lang/rust#165990 (gca fixed issue regression tests)
 - rust-lang/rust#165993 (pipe_subprocess test: use libtest harness)
 - rust-lang/rust#165998 (Cleanup borrowck)
 - rust-lang/rust#166005 (add ABI compat checks for new float types)
 - rust-lang/rust#166009 (Improve `String::insert{,_str}` safety comments)
 - rust-lang/rust#166021 (Correct and expand E0225 error explanation.)
 - rust-lang/rust#166029 (rustc-dev-guide subtree update)
 - rust-lang/rust#166031 (Split packed structs out of `const_struct`)
 - rust-lang/rust#166032 (Normalize the simd field type before reading its length)
 - rust-lang/rust#166034 (Three LLVM-type-related cleanups)
 - rust-lang/rust#166047 (Document AltiVec requirement for powerpc64-unknown-linux-gnuelfv2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-str Area: `str` and `String` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants